nonspammy KDE builds?

classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

Christian Boltz-5
Hello,

Am Dienstag, 12. Dezember 2017 schrieb John Paul Adrian Glaubitz:
> On 12/11/2017 11:10 PM, Michael Matz wrote:

> > Well, what do you want me to say?  Yes, it looks suboptimal in the
> > browser.  It would be nice if it would look nicer.  Is anyone going
> > to implement non-line-wrapping in firefox?  I doubt it.  Is anyone
> > going to implement a non-raw mode for the build log URL like
> > debian?  Perhaps, that would be nice.  Is saying any of these
> > things giving a solution to the problem that works right now?  No.
> > So why mention them?
>
> This isn't an issue in Firefox. This is an issue with OBS which
> doesn't offer a web-browser compatible log file. The Debian solution
> works just fine. Offer an HTML-encapsulated log file for the browser

The CSS for the OBS web interface has (simplified)
    pre { white-space: pre-wrap; }
which is the reason for the line wraps.

If you don't want to have the line wraps, you can add a user stylesheet
to your browser, and add something like this to it:
    pre#log_space { white-space: pre !important; }

You might want to make the selector more specific to avoid accidentional
matches on other pages, but the above should be good enough to get
started.


Needless to say that horicontal scrolling is a matter of taste, and
personally I prefer linebreaks in build logs over horicontal scrolling.
That's the good thing with a user stylesheet - you can adjust it for
your needs without annoying those who prefer the line-wrapped version.

> plus a link
> to the raw log:

You mean, like the "Download logfile" link in OBS which delivers the log
as text/plain?


> https://buildd.debian.org/status/fetch.php?
> pkg=gcc-7&arch=i386&ver=7.2.0-17&stamp=1512511504&raw=0

What Debian delivers is a HTML page with a big <pre> containing the
logfile. That's not as raw as what our "Download logfile" delivers ;-)
but since they use "white-space: pre;" and not "pre-wrap", it is closer
to your taste.


Regards,

Christian Boltz
--
[Re: Status of 2.2 release?]
Erm.. Christian tends to keep creating new 'blocker' tickets
(normally when he closes another!) ... :)
[GingerDog in https://sourceforge.net/forum/message.php?msg_id=4895826]

--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

John Paul Adrian Glaubitz
On 12/12/2017 01:45 PM, Christian Boltz wrote:

> The CSS for the OBS web interface has (simplified)
>      pre { white-space: pre-wrap; }
> which is the reason for the line wraps.
>
> If you don't want to have the line wraps, you can add a user stylesheet
> to your browser, and add something like this to it:
>      pre#log_space { white-space: pre !important; }
>
> You might want to make the selector more specific to avoid accidentional
> matches on other pages, but the above should be good enough to get
> started.
>
>
> Needless to say that horicontal scrolling is a matter of taste, and
> personally I prefer linebreaks in build logs over horicontal scrolling.
> That's the good thing with a user stylesheet - you can adjust it for
> your needs without annoying those who prefer the line-wrapped version.

Which again requires additional configuration and more work. The Debian
version works out of the box. Not everyone wants to deal with CSS or
knows any CSS, including me. I just want a version that displays nicely
in the browser and the raw log. Debian has that, OBS doesn't.

>> plus a link
>> to the raw log:
>
> You mean, like the "Download logfile" link in OBS which delivers the log
> as text/plain?

I mean the missing HTML-encapsulated version in OBS. Debian has both,
a version that renders nicely in the browser and the raw text version
which can be reached by clicking "text".

>> https://buildd.debian.org/status/fetch.php?
>> pkg=gcc-7&arch=i386&ver=7.2.0-17&stamp=1512511504&raw=0
>
> What Debian delivers is a HTML page with a big <pre> containing the
> logfile. That's not as raw as what our "Download logfile" delivers ;-)
> but since they use "white-space: pre;" and not "pre-wrap", it is closer
> to your taste.

You did not click "text" in the Debian logs. This gives me the raw text
log:

> https://buildd.debian.org/status/fetch.php?pkg=gcc-7&arch=ppc64&ver=7.2.0-17&stamp=1512495866&raw=1

Adrian
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

Jan Engelhardt-4

On Tuesday 2017-12-12 13:51, John Paul Adrian Glaubitz wrote:

> On 12/12/2017 01:45 PM, Christian Boltz wrote:
>> Needless to say that horicontal scrolling is a matter of taste, and
>> personally I prefer linebreaks in build logs over horicontal scrolling.
>> That's the good thing with a user stylesheet - you can adjust it for
>> your needs without annoying those who prefer the line-wrapped version.
>
> Which again requires additional configuration and more work. The Debian
> version works out of the box. Not everyone wants to deal with CSS or
> knows any CSS, including me. I just want a version that displays nicely
> in the browser and the raw log. Debian has that, OBS doesn't.

Open a feature request on github.com/openSUSE/open-build-service
to show e.g. a checkbox which toggles the CSS with JS.
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

Stefan Seyfried
In reply to this post by John Paul Adrian Glaubitz
On 12.12.2017 11:32, John Paul Adrian Glaubitz wrote:
> As for patching Firefox, getting such patches upstreamed isn't trivial
> as Mozilla is very nit-picky about accepting patches and it usually
> takes a lot of discussion to get them to merge things.

I have good news for you: getting patches into OBS is not very hard, so you can probably easily get your patch to offer
a "view Logfile" link next to the "download logfile" link in.

If the OBS community is hostile to you, please come back and I will try to help you get your patch in.
--
Stefan Seyfried

"For a successful technology, reality must take precedence over
 public relations, for nature cannot be fooled." -- Richard Feynman
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

John Paul Adrian Glaubitz
On 12/12/2017 03:28 PM, Stefan Seyfried wrote:
> I have good news for you: getting patches into OBS is not very hard, so you can probably easily get your patch to offer
> a "view Logfile" link next to the "download logfile" link in.

I am an upstream person. If I fix something, I usually fix it upstream.

Adrian
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

Dominique Leuenberger / DimStar
On Tue, 2017-12-12 at 16:57 +0100, John Paul Adrian Glaubitz wrote:
> On 12/12/2017 03:28 PM, Stefan Seyfried wrote:
> > I have good news for you: getting patches into OBS is not very
> > hard, so you can probably easily get your patch to offer
> > a "view Logfile" link next to the "download logfile" link in.
>
> I am an upstream person. If I fix something, I usually fix it
> upstream.
>
> Adrian

https://github.com/openSUSE/open-build-service/ is the upstream for OBS
- happy hacking?  :)

Cheers,
Dominique

signature.asc (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: nonspammy KDE builds?

John Paul Adrian Glaubitz
On 12/12/2017 05:11 PM, Dominique Leuenberger / DimStar wrote:
> https://github.com/openSUSE/open-build-service/ is the upstream for OBS
> - happy hacking?  :)

Sounds like a thing that I can put on my upstream TODO list, yes.

Adrian
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

12