'kvm_rng_device' is not a valid device model name

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

'kvm_rng_device' is not a valid device model name

Dinar Valeev
Hi,
We have Power workers failing constantly with 'kvm_rng_device' is not
a valid device model name, this is a result of part of qemu command:
-object rng-random,filename=/dev/hwrng,id=rng0 -device kv
m_rng_device,rng=rng0

I wonder why $kvm_rng_device [1] is not expanded here?

[1] https://github.com/openSUSE/obs-build/blob/master/build-vm-kvm#L196

Dinar,
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: 'kvm_rng_device' is not a valid device model name

Andreas Schwab
Dinar Valeev <[hidden email]> writes:

> Hi,
> We have Power workers failing constantly with 'kvm_rng_device' is not
> a valid device model name, this is a result of part of qemu command:
> -object rng-random,filename=/dev/hwrng,id=rng0 -device kv
> m_rng_device,rng=rng0
>
> I wonder why $kvm_rng_device [1] is not expanded here?
>
> [1] https://github.com/openSUSE/obs-build/blob/master/build-vm-kvm#L196

This is not the file that is distributed by backend-opensuse.  The real
file has the following difference:

@@ -189,11 +189,8 @@
         if test -c /dev/hwrng &&
            test -f /sys/class/misc/hw_random/rng_current &&
            test "$(cat /sys/class/misc/hw_random/rng_current)" != none; then
-            rng_dev="/dev/hwrng"
-        else
-            rng_dev="/dev/random"
+            kvm_options="$kvm_options -object rng-random,filename=/dev/hwrng,id=rng0 -device kvm_rng_device,rng=rng0"
         fi
-        kvm_options="$kvm_options -object rng-random,filename=$rng_dev,id=rng0 -device $kvm_rng_device,rng=rng0"
     fi
 }
 

Andreas.

--
Andreas Schwab, [hidden email]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: 'kvm_rng_device' is not a valid device model name

Dinar Valeev
On Sat, Nov 28, 2015 at 10:19 AM, Andreas Schwab <[hidden email]> wrote:

> Dinar Valeev <[hidden email]> writes:
>
>> Hi,
>> We have Power workers failing constantly with 'kvm_rng_device' is not
>> a valid device model name, this is a result of part of qemu command:
>> -object rng-random,filename=/dev/hwrng,id=rng0 -device kv
>> m_rng_device,rng=rng0
>>
>> I wonder why $kvm_rng_device [1] is not expanded here?
>>
>> [1] https://github.com/openSUSE/obs-build/blob/master/build-vm-kvm#L196
>
> This is not the file that is distributed by backend-opensuse.  The real
> file has the following difference:
I restarted a worker to get a new obs-build code. But it still gets a
wrong one. Maybe I'm getting it from wrong source server.

starting worker 15cbea9430806f99454fcac26cdc691b build
d41d8cd98f00b204e9800998ecf8427e
fetching new buildcode b6d7f1f482bddff38d0bbff1970a388b, mine was
d41d8cd98f00b204e9800998ecf8427e
got job, run build...

> @@ -189,11 +189,8 @@
>          if test -c /dev/hwrng &&
>             test -f /sys/class/misc/hw_random/rng_current &&
>             test "$(cat /sys/class/misc/hw_random/rng_current)" != none; then
> -            rng_dev="/dev/hwrng"
> -        else
> -            rng_dev="/dev/random"
> +            kvm_options="$kvm_options -object rng-random,filename=/dev/hwrng,id=rng0 -device kvm_rng_device,rng=rng0"
>          fi
> -        kvm_options="$kvm_options -object rng-random,filename=$rng_dev,id=rng0 -device $kvm_rng_device,rng=rng0"
>      fi
>  }
>
>
> Andreas.
>
> --
> Andreas Schwab, [hidden email]
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: 'kvm_rng_device' is not a valid device model name

Andreas Schwab
Dinar Valeev <[hidden email]> writes:

> I restarted a worker to get a new obs-build code. But it still gets a
> wrong one. Maybe I'm getting it from wrong source server.

The worker by default always uses the build code from the backend.

Andreas.

--
Andreas Schwab, [hidden email]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]