factory-auto says "Unknown tag: bad spec python-wheel.spec"

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

factory-auto says "Unknown tag: bad spec python-wheel.spec"

Sebastian-2
Hi,

This request: https://build.opensuse.org/request/show/512806

got declined by factory-auto with this comment:
> Output of check script:
> Source validator failed. Try "osc service localrun source_validator"
>  
https://files.pythonhosted.org/packages/source/w/wheel/wheel-0.29.0.tar.gz
https://files.pythonhosted.org/packages/source/w/wheel/wheel-0.29.0.tar.gz
error: line 21: Unknown tag: bad spec python-wheel.spec

What does this mean? When running the specified command locally, I don't
get this error.
I got this error sometime in the last months in another request too, but
I don't remember which one it was now.

Sebastian

--
python programming - mail server - photo - video - https://sebix.at
cryptographic key at https://sebix.at/DC9B463B.asc and on public keyservers



signature.asc (871 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: factory-auto says "Unknown tag: bad spec python-wheel.spec"

Bruno Friedmann-2
On samedi, 29 juillet 2017 18.03:46 h CEST Sebastian wrote:

> Hi,
>
> This request: https://build.opensuse.org/request/show/512806
>
> got declined by factory-auto with this comment:
> > Output of check script:
> > Source validator failed. Try "osc service localrun source_validator"
>
> https://files.pythonhosted.org/packages/source/w/wheel/wheel-0.29.0.tar.gz
> https://files.pythonhosted.org/packages/source/w/wheel/wheel-0.29.0.tar.gz
> error: line 21: Unknown tag: bad spec python-wheel.spec
>
> What does this mean? When running the specified command locally, I don't
> get this error.
> I got this error sometime in the last months in another request too, but
> I don't remember which one it was now.
>
> Sebastian

Hard to tell like this but I've seen during singlespec conversion lot of
strange erros like this. rpm-macros is quite sensible.

Perhaps line 20 where you have
%{!?license: %global license %doc}
it would be better to move it up.


--

Bruno Friedmann
 Ioda-Net Sàrl www.ioda-net.ch
 Bareos Partner, openSUSE Member, fsfe fellowship
 GPG KEY : D5C9B751C4653227
 irc: tigerfoot


--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: factory-auto says "Unknown tag: bad spec python-wheel.spec"

jan matejek-4
hello,
On 30.7.2017 01:48, Bruno Friedmann wrote:
>> error: line 21: Unknown tag: bad spec python-wheel.spec
>
> Perhaps line 20 where you have
> %{!?license: %global license %doc}
> it would be better to move it up.

not the cause here though.

The error message is bad and I'll change it in the next python-rpm-macros update, but

What it means is that the rewriter can't find the spec file.
factory-auto is doing this thing again where they check spec files that are NOT called %{name}.spec,
or maybe they're in some unexpected path, I don't know.

CC for Jim and Ludwig, to whom I talked about this last time.
Guys, please tell me what exactly your factory bot is doing with specs, so that I can expect this
and fix it in python-rpm-macros? Or where its code lives, so that I can take a look for myself?

regards
m.


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: factory-auto says "Unknown tag: bad spec python-wheel.spec"

Jimmy Berry-2
On Wednesday, August 2, 2017 7:22:59 AM CDT jan matejek wrote:

> hello,
>
> On 30.7.2017 01:48, Bruno Friedmann wrote:
> >> error: line 21: Unknown tag: bad spec python-wheel.spec
> >
> > Perhaps line 20 where you have
> > %{!?license: %global license %doc}
> > it would be better to move it up.
>
> not the cause here though.
>
> The error message is bad and I'll change it in the next python-rpm-macros
> update, but
>
> What it means is that the rewriter can't find the spec file.
> factory-auto is doing this thing again where they check spec files that are
> NOT called %{name}.spec, or maybe they're in some unexpected path, I don't
> know.
>
> CC for Jim and Ludwig, to whom I talked about this last time.
> Guys, please tell me what exactly your factory bot is doing with specs, so
> that I can expect this and fix it in python-rpm-macros? Or where its code
> lives, so that I can take a look for myself?
>
> regards
> m.

The parts of the bot in question are:

https://github.com/openSUSE/osc-plugin-factory/blob/master/check_source.py#L85
https://github.com/openSUSE/osc-plugin-factory/blob/master/source-checker.pl

I did some digging and it seems to choke on %{python_subpackages} during the
20-files-present-and-referenced validator. Interestingly it does not produce
the failure when run via `osc service localrun source_validator` as it
suggests. I filed an issue with the details:
  https://github.com/openSUSE/obs-service-source_validator/issues/50

Seems to be something screwy related to the validator so it should likely be
resolved there, but let me know if not.

If you are interested in running the bot exactly as it does use the following.
  ./check_source.py --dry --debug --osc-debug id 512806

The call to the validator in question is in the .pl file.

--
Jimmy
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: factory-auto says "Unknown tag: bad spec python-wheel.spec"

jan matejek-4
On 2.8.2017 16:17, Jimmy Berry wrote:

> I did some digging and it seems to choke on %{python_subpackages} during the
> 20-files-present-and-referenced validator. Interestingly it does not produce
> the failure when run via `osc service localrun source_validator` as it
> suggests. I filed an issue with the details:
>   https://github.com/openSUSE/obs-service-source_validator/issues/50
>
> Seems to be something screwy related to the validator so it should likely be
> resolved there, but let me know if not.
>
> If you are interested in running the bot exactly as it does use the following.
>   ./check_source.py --dry --debug --osc-debug id 512806
>
> The call to the validator in question is in the .pl file.
Thanks for looking into it. I'll play around with it too.

moving the discussion to the mentioned github issue

m.


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: factory-auto says "Unknown tag: bad spec python-wheel.spec"

Sebastian-2
In reply to this post by Sebastian-2
The problem seems to be fixed now.

For reference, this bug occurred too, further blocking submissions:
https://bugzilla.opensuse.org/show_bug.cgi?id=1053969

--
python programming - mail server - photo - video - https://sebix.at
cryptographic key at https://sebix.at/DC9B463B.asc and on public keyservers



signature.asc (871 bytes) Download Attachment