[PATCH] update default list of request states

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] update default list of request states

Dirk Müller

Hi,

"declined" was some time ago changed to be considered an "open" request state.

the default behavior of "osc rq list" is IMHO to show open requests (requests
in state new or review), so I'm attaching a patch that adds "declined" as
well.


Tia,
Dirk


0001-add-declined-to-list-of-default-states-for-rq-list.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update default list of request states

Marcus Hüwe
Hi,

On 2012-09-10 10:43:28 +0200, Dirk Müller wrote:
> "declined" was some time ago changed to be considered an "open" request state.
>
Hmm what exactly is an open state? A "non final" state? If so we also have
to add "revoked" to the list.

> the default behavior of "osc rq list" is IMHO to show open requests (requests
> in state new or review), so I'm attaching a patch that adds "declined" as
> well.


Marcus
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update default list of request states

Adrian Schröter
Am Montag, 10. September 2012, 11:13:06 schrieb Marcus Hüwe:
> Hi,
>
> On 2012-09-10 10:43:28 +0200, Dirk Müller wrote:
> > "declined" was some time ago changed to be considered an "open" request state.
> >
> Hmm what exactly is an open state? A "non final" state?

yes

> If so we also have
> to add "revoked" to the list.

No, revoked is final. It says it got refused and the submitter accepts it. While
declined could be just a misunderstanding or question back.
This got introduced to avoid the situation that a submission got declined and the
submitter does not notice. So he has either to accept that (revoke), reopen the request
or superseed (fixing the decline reason).

Dirk, you patch is applied now.

thanks
adrian

> > the default behavior of "osc rq list" is IMHO to show open requests (requests
> > in state new or review), so I'm attaching a patch that adds "declined" as
> > well.
>
>
> Marcus
>
--
Adrian Schroeter
SUSE Linux Products GmbH
email: [hidden email]
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]