How are Factory->Leap submissions supposed to be handled?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

How are Factory->Leap submissions supposed to be handled?

Olaf Hering-2
I receive "review" requests for Leap, but essentially can just silently
accept the fact that a pkg is copied from Factory to Leap at some point.

Result is:
# obs review decline 565049 -m "$msg"
No permission on review by user leaper:
HTTP Error 403: Forbidden
No permission on review by group factory-auto
HTTP Error 403: Forbidden
No permission on review by group factory-staging
HTTP Error 403: Forbidden

What is the point of these review mails?

Olaf

signature.asc (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: How are Factory->Leap submissions supposed to be handled?

Jan Engelhardt-4
On Monday 2018-01-15 13:36, Olaf Hering wrote:

>I receive "review" requests for Leap, but essentially can just silently
>accept the fact that a pkg is copied from Factory to Leap at some point.
>
>Result is:
># obs review decline 565049 -m "$msg"
>No permission on review by user leaper:
>HTTP Error 403: Forbidden
>No permission on review by group factory-auto
>HTTP Error 403: Forbidden
>No permission on review by group factory-staging
>HTTP Error 403: Forbidden
>
>What is the point of these review mails?

This is a bug^H^H^H unfortunate feature in osc. When you osc
accept/decline/etc. something, it tries to edit *all* open reviews on the SR -
of which there are often something like 4 to 6 - even if you do not have
permission to some of them (because a bot owns it).

565049 has four:

Review:  new        Group: leap-reviewers                              2018-01-15T12:51:32 leaper
         new        Package: X11:wxWidgets/wxsqlite3                   2018-01-15T12:51:30 leaper
         new        Group: factory-staging                             2018-01-15T12:22:14
         new        Group: factory-auto                                2018-01-15T12:22:14

factory items have aroud six:

        Review by Group      is accepted:  legal-auto(licensedigger)                        
        Review by Group      is accepted:  factory-auto(factory-auto)                        
        Review by Group      is accepted:  factory-staging(staging-bot)                      
        Review by Group      is new:       opensuse-review-team(factory-auto)                
        Review by User       is accepted:  repo-checker(repo-checker)                        
        Review by Project    is new:       openSUSE:Factory:Staging:adi:17(staging-bot)      
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: How are Factory->Leap submissions supposed to be handled?

Max Lin
In reply to this post by Olaf Hering-2
Hi,

On 01/15/2018 08:36 PM, Olaf Hering wrote:

> I receive "review" requests for Leap, but essentially can just silently
> accept the fact that a pkg is copied from Factory to Leap at some point.
>
> Result is:
> # obs review decline 565049 -m "$msg"
> No permission on review by user leaper:
> HTTP Error 403: Forbidden
> No permission on review by group factory-auto
> HTTP Error 403: Forbidden
> No permission on review by group factory-staging
> HTTP Error 403: Forbidden

That is due to osc review command in default can not see it has also had
by_project/by_package review IIRC, try osc review decline [-P PROJECT
[-p PACKAGE]] 565049 -m msg.

Regards,
Max
--
To unsubscribe, e-mail: [hidden email]
To contact the owner, e-mail: [hidden email]